This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
fix build html5/hybrid bug for shared mojits #813
Merged
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url metadata for shared/app-level mojits is in a special mojit named "Shared", not via the mojit it was packaged in.
|
Travis: "Executing your script (./travis/script.sh) took longer than 30 minutes and was terminated." |
| "app-level" (aka shared) mojits get uris via a special RS mojit named | ||
| "Shared", not via the mojit they came in */ | ||
| if (mojit.hasOwnProperty('url')) { | ||
| uri = mojit.url + '/definition.json'; |
There was a problem hiding this comment.
In general I prefer "builders" so we avoid the assumption about whether there's a / needed or not. But +1 :).
|
+1 |
isao
pushed a commit
that referenced
this pull request
Nov 30, 2012
fix build html5/hybrid bug for shared mojits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change skips processing client mojit metadata without a url (url metadata for shared/app-level mojits is in a special mojit named "Shared", not via the mojit it was packaged in.). It fixes the
mojito buildfailure for a app with shared resources; i.e.mojito buildin ./tests/func/applications/frameworkapp/common before this patch threw an error like this: